windows: add feature std for winapi #4663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonhoo
approved these changes
May 8, 2022
Thomasdezeeuw
approved these changes
May 8, 2022
jonhoo
approved these changes
May 8, 2022
|
Will a new release be created for this hot-fix? |
Darksonn
added a commit
that referenced
this pull request
May 8, 2022
Merged
Darksonn
added a commit
that referenced
this pull request
May 8, 2022
Closed
|
Yes, see #4666. |
Darksonn
added a commit
that referenced
this pull request
May 8, 2022
43 tasks
Darksonn
added a commit
that referenced
this pull request
May 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching from winapi to windows-sys in mio means that the
stdfeature of winapi is no longer enabled when compiling Tokio on windows. However, in this case, thec_voidtype is not the same as thec_voidtype in the standard library, which causes some compiler errors in various places.(The first commit to this PR does not add the feature to verify that CI catches the issue when its not fixed.)
Closes: #4662