chore: fix ci by hard-coding nightly version for miri #4825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It would seem that the latest nightly is having issues, so I went with the one from yesterday (2022-7-10).
Noah-Kennedy
force-pushed
the
noah/fix-miri
branch
from
3dba096
to
dab8735
Compare
Noah-Kennedy
requested review from
hawkw,
carllerche and
ipetkov
and removed request for
hawkw
Noah-Kennedy
added a commit
that referenced
this pull request
Jul 13, 2022
This reverts [#4825], which was to address Miri being broken on the latest nightly, possibly due to an issue in rustup. Rustup issue: rust-lang/rustup#3031 [#4825]: #4825
Noah-Kennedy
added a commit
that referenced
this pull request
Jul 13, 2022
This reverts [#4825], as miri seems to be working again on the latest nightly. I had originally thought it was this issue with rustup which was to blame, but this seems to be wrong: rust-lang/rustup#3031 [#4825]: #4825
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would seem that the latest nightly is having issues, so I went with the one from yesterday (2022-7-10).