Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tokio-util: implement StreamedFd #5362

Closed
wants to merge 6 commits into from
Closed

tokio-util: implement StreamedFd #5362

wants to merge 6 commits into from

Conversation

Noah-Kennedy
Copy link
Contributor

StreamedFd is a higher-level wrapper around an AsyncFd which provides the PollEvented optimization to users.

Fixes #5324.

io: implement StreamedFd
83a398c 
StreamedFd is a higher-level wrapper around an AsyncFd which provides the PollEvented optimization to users.

Fixes #5324.
@Noah-Kennedy
Copy link
Contributor Author

I'd like to seek comment here regarding the naming and API, especially around flush and shutdown within the AsyncWrite implementation.

@Noah-Kennedy Noah-Kennedy changed the title io: implement StreamedFd tokio-util: implement StreamedFd Jan 7, 2023
NobodyXu
NobodyXu suggested changes Jan 7, 2023
View reviewed changes
tokio-util/src/io/stream_fd.rs Outdated Show resolved Hide resolved
@NobodyXu
Copy link
Contributor

NobodyXu commented Jan 7, 2023

StreamedFd sounds a bit confusing, it makes me feels like it's an adaptor that makes the underlying fd streamed.

How about ByteStreamFd?

@Noah-Kennedy
Copy link
Contributor Author

Thanks, I really hated the name StreamFd. Your name is much better.

@Noah-Kennedy
Copy link
Contributor Author

Alright, as far as bikeshedding the name is concerned, we've currently got StreamFd and ByteStreamFd. Does anyone have any better ideas?

@NobodyXu NobodyXu mentioned this pull request Jan 7, 2023
Closed
@Darksonn Darksonn added A-tokio-util Area: The tokio-util crate M-io Module: tokio/io labels Jan 7, 2023
@Darksonn
Copy link
Contributor

This has been an untouched draft for a long time. For now, I'll close it.

@Darksonn Darksonn closed this Nov 25, 2023
@Darksonn Darksonn deleted the noah/streamed-fd-tokio-util branch November 25, 2023 12:18
@Darksonn Darksonn mentioned this pull request Mar 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NobodyXu NobodyXu NobodyXu requested changes

Assignees
No one assigned
Labels
A-tokio-util Area: The tokio-util crate M-io Module: tokio/io
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Performance reading from serial ports suffers due to excessive read() calls
3 participants
@Noah-Kennedy @NobodyXu @Darksonn