Move tokio_io::io to tokio::io

[phungleson]

Motivation

Move tokio_io::io to tokio::io as part of #354

Solution

As suggested in #354

There are a few places need some discussions, read below.

[phungleson]

This was commented out due to conflicts with pub use self::read::{read, Read}; above.

What should we do in this case?

[hawkw]

I'm not sure what we ought to do about that one off the top of my head --- would love to get @carllerche's opinion.

[carllerche]

The two options here are to keep the types in a sub module or to rename them...

Given that the types themselves are less useful, I would opt to keep them in a submodule. I'm not sure what to name it though.

[phungleson]

This is needed as tokio::io needs to pub use it, so the temp docs in trunk below is needed.

What should we do in this case?

[hawkw]

Since tokio-io exports lines/Lines publicly in the tokio_io::io module (although the code lives in the private tokio_io::lines module), and we're moving everything in tokio_io::io, I think we ought to copy the lines module into tokio::io as well. Then, tokio::io can just pub use self::lines::{lines, Lines}, and we don't have to make thispub.

We should be able to deprecate the lines exported in the old location after doing so.

[hawkw]

You're definitely on the right track here, this looks good.

I noticed that when I checked out this branch and ran the tests, the test tests/pipe_hup.rs still uses read_to_end from the old (deprecated) location:

warning: use of deprecated item 'tokio_io::io::read_to_end': Moved to tokio::io
  --> tests/pipe-hup.rs:20:5
   |
20 | use tokio_io::io::read_to_end;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: #[warn(deprecated)] on by default

warning: use of deprecated item 'tokio_io::io::read_to_end': Moved to tokio::io
  --> tests/pipe-hup.rs:83:22
   |
83 |         let reader = read_to_end(source, Vec::new());
   |                      ^^^^^^^^^^^

Mind fixing that?

[hawkw]

I believe this should say "Moved to tokio::io"?

[hawkw]

Same as above --- this was moved to tokio::io, not tokio-codec.

[hawkw]

Since tokio-io exports lines/Lines publicly in the tokio_io::io module (although the code lives in the private tokio_io::lines module), and we're moving everything in tokio_io::io, I think we ought to copy the lines module into tokio::io as well. Then, tokio::io can just pub use self::lines::{lines, Lines}, and we don't have to make thispub.

We should be able to deprecate the lines exported in the old location after doing so.

[hawkw]

I'm not sure what we ought to do about that one off the top of my head --- would love to get @carllerche's opinion.

[phungleson]

Hey @hawkw I made the changes, and travis shows some weird warning, do you think we should fix in a separate PR?

[hawkw]

@phungleson those warnings should be fixed in #575.

[carllerche]

So... I just realized that this is going to be a breaking change... moving the functions over means that the return types are different and anything that has depended on them in the past will break... :(

That means this change cannot be applied until 0.2, which is sad.

[carllerche]

I'm going to close this PR for now simply since no further action can be taken until a breaking change happens. However, it is tracked by #591 and once the time comes, I will open it again.

Thanks for the work!