Deprecate and replace Runtime::threadpool_builder #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
tobz
approved these changes
Sep 19, 2018
|
I restarted CI and filed #647 to track fixing the spurious failure. |
dekellum
added a commit
to dekellum/body-image
that referenced
this pull request
Oct 14, 2018
tokio-rs/tokio#645 deprecated `tokio::runtime::Builder::threadpool_builder` with the following message: use of deprecated item 'tokio::runtime::Builder::threadpool_builder': use the `core_threads`, `blocking_threads`, `name_prefix`, and `stack_size` functions on `runtime::Builder`, instead The was originally released in tokio 0.1.9. Subsequently tokio 0.1.10 and 0.1.11 were released as (purely semver) bug fixes of the former, so make 0.1.11 the new minimum along with this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, the concurrent Runtime is configured by passing in a
threadpool builder. This is problematic for two reasons:
tokio-threadpoolas part of thetokiopublic API,preventing
tokiofrom transparently bumping the version usedinternally.
maintained. There are some that the Runtime must set, overwriting
previously set values.
Solution
This branch makes the following changes:
threadpool_builder.core_threadsrepresentingpool_sizeon the threadpool builder.blocking_threadsrepresentingmax_blockingon the threadpool builder.name_prefix, mirroring the same fn on the threadpool builder.stack_size, mirroring the same fn on the threadpool builder.Fixes: #642
Signed-off-by: Eliza Weisman eliza@buoyant.io