Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync: fix incorrect is_empty on mpsc block boundaries #6603

Merged
merged 1 commit into from
May 30, 2024
Merged

sync: fix incorrect is_empty on mpsc block boundaries #6603

merged 1 commit into from
May 30, 2024

Conversation

Darksonn
Copy link
Contributor

Fixes: #6602

@Darksonn Darksonn added A-tokio Area: The main tokio crate M-sync Module: tokio/sync labels May 30, 2024
@github-actions github-actions bot added the R-loom-sync Run loom sync tests on this PR label May 30, 2024
This was referenced May 30, 2024
Closed
Merged
hds
hds approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@hds hds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@carllerche carllerche merged commit dbf93c7 into master May 30, 2024
77 checks passed
@carllerche carllerche deleted the alice/fix-6602 branch May 30, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hds hds hds approved these changes

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate M-sync Module: tokio/sync R-loom-sync Run loom sync tests on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Every 32 messages is_empty() on Receiver and UnboundedReceiver returns false even though len == 0
3 participants
@Darksonn @hds @carllerche