-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AbortOnDropHandle
type
#6786
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barafael
force-pushed
the
rb/abort_handle
branch
from
August 17, 2024 17:17
eae386e
to
85984fd
Compare
Darksonn
added
A-tokio-util
Area: The tokio-util crate
M-task
Module: tokio/task
labels
Aug 19, 2024
Darksonn
reviewed
Aug 19, 2024
barafael
force-pushed
the
rb/abort_handle
branch
2 times, most recently
from
August 19, 2024 12:45
7e47811
to
cf7cfd4
Compare
Darksonn
reviewed
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good.
barafael
force-pushed
the
rb/abort_handle
branch
from
August 19, 2024 13:36
d5dfa0a
to
79b80e7
Compare
wraps a `JoinHandle`, aborting the task on drop Co-authored-by: Alice Ryhl <aliceryhl@google.com> Refs: tokio-rs#6224 Fixes: tokio-rs#6160
barafael
force-pushed
the
rb/abort_handle
branch
from
August 19, 2024 13:58
79b80e7
to
dd4f2a9
Compare
Darksonn
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Thanks for finishing this! |
@dev-ardi thanks for starting it :) |
This is great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wraps a
JoinHandle
, aborting the task on dropRefs: #6224
Fixes: #6160