Avoid pointer casts in IO driver on miri #6859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alice Ryhl <aliceryhl@google.com>
Darksonn
added
A-tokio
RalfJung
reviewed
Sep 22, 2024
Darksonn
commented
Sep 22, 2024
mox692
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Miri is being improved to support epoll, which means that we will be able to support a much larger fraction of Tokio's test suite under miri. That is being tracked in #6812. This PR removes our usage of ptr2int2ptr roundtrips when running under miri for better miri compatibility.
cc @RalfJung @tiif