Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UdpCodec::encode #85

Merged
merged 3 commits into from
Jan 16, 2018
Merged

Fix UdpCodec::encode #85

merged 3 commits into from
Jan 16, 2018

Conversation

kpp
Copy link
Contributor

@kpp kpp commented Jan 12, 2018

Change the signature of UdpCodec::encode

Now it is:

fn encode(&mut self, msg: Self::Out, buf: &mut Vec<u8>)
                                              -> Result<SocketAddr, Self::Error>;

Closes #79

@kpp
Fix compilation error from mio crate
f573e9c
@kpp
Refactor UDP SendDgram & RecvDgram
346900b 
    Get rid of unnamed structs in the favor of private structs with named fields
@kpp
Change the signature of UdpCodec::encode
4075601 
    Now it is:

    ```
        fn encode(&mut self, msg: Self::Out, buf: &mut Vec<u8>) -> Result<SocketAddr, Self::Error>;
    ```

    Closes tokio-rs#79
This was referenced Jan 15, 2018
Closed
Closed
@alexcrichton
Copy link
Contributor

Thanks @kpp!

@alexcrichton alexcrichton merged commit 025f52a into tokio-rs:new-crate Jan 16, 2018
@kpp kpp deleted the fix_udp_codec_encode_79 branch January 16, 2018 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcrichton alexcrichton alexcrichton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kpp @alexcrichton