Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support std::future #117

Closed
davidbarsky opened this issue Jun 28, 2019 · 4 comments
Closed

Support std::future #117

davidbarsky opened this issue Jun 28, 2019 · 4 comments
Labels
crate/futures Related to the `tracing-futures` crate kind/feature New feature or request

Comments

@davidbarsky
Copy link
Member

This is pretty important for a 0.1 tracing release.

@davidbarsky davidbarsky added this to the tracing 0.1 milestone Jun 28, 2019
@hawkw
Copy link
Member

hawkw commented Jun 28, 2019

This isn't necessary for tracing v0.1, as it doesn't actually touch the tracing crate --- this change would be in tracing-futures. I'd definitely call it a release blocker for that crate though!

@hawkw hawkw added crate/futures Related to the `tracing-futures` crate kind/feature New feature or request labels Jun 28, 2019
@hawkw hawkw removed this from the tracing 0.1 milestone Jun 28, 2019
@mbilker
Copy link
Contributor

mbilker commented Jul 4, 2019

I sort of have this working in a local build that I did awhile ago. I'll have to see if I can get it working again and see if I can shave off the need to have the type be Instrumented<Pin<Box<T>> to get Unpin.

@mbilker
Copy link
Contributor

mbilker commented Jul 4, 2019

I put up my current work over at https://github.com/mbilker/tracing/tree/std-future. Currently, you have to call boxed_instrument when working with std::future so the inner future gets pinned.

@davidbarsky
Copy link
Member Author

With the merging of #40, I think we can close this issue now!

@hawkw hawkw added this to the tracing-futures 0.1 milestone Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crate/futures Related to the `tracing-futures` crate kind/feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants