log: revert #2740 #2750
Merged
log: revert #2740 #2750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkw
approved these changes
Oct 12, 2023
davidbarsky
added a commit
that referenced
this pull request
Oct 12, 2023
This was referenced Oct 12, 2023
Merged
This was referenced Oct 23, 2023
hawkw
added a commit
that referenced
this pull request
Oct 24, 2023
Removing the `env_logger` feature in order to address GHSA-g98v-hv3f-hcfr. In addition, this PR also removes the deprecated `trace_logger` module, in preparation for an upcoming v0.2.0 of `tracing-log`. For additional details on the approach, please refer to #2750. Note that this PR depends on #2770, so this PR will temporarily have more commits than intended. --------- Co-authored-by: Eliza Weisman <eliza@buoyant.io>
kaffarell
pushed a commit
to kaffarell/tracing
that referenced
this pull request
Nov 21, 2023
kaffarell
pushed a commit
to kaffarell/tracing
that referenced
this pull request
May 22, 2024
…#2771) Removing the `env_logger` feature in order to address GHSA-g98v-hv3f-hcfr. In addition, this PR also removes the deprecated `trace_logger` module, in preparation for an upcoming v0.2.0 of `tracing-log`. For additional details on the approach, please refer to tokio-rs#2750. Note that this PR depends on tokio-rs#2770, so this PR will temporarily have more commits than intended. --------- Co-authored-by: Eliza Weisman <eliza@buoyant.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to minimum version selection issues, a desire to remove the
env_loggerfeature wholesale, and to keep the number of breaking changes to a minimum, I'm reverting #2740 in favor of marking thetracing-log/env_loggerfeature as deprecated and releasingtracing-log0.2.0 withoutenv_logger.