chore: prepare tracing-log 0.2.0 #2772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidbarsky
force-pushed
the
david/prepare-tracing-log-0.2.0
branch
from
f1184b9
to
5d913c4
Compare
davidbarsky
force-pushed
the
david/prepare-tracing-log-0.2.0
branch
from
6c110bd
to
d018fad
Compare
hawkw
requested changes
Oct 24, 2023
tracing-log/CHANGELOG.md
Outdated
Comment on lines
3
to
14
| This release contains two breaking changes: the removal of the `env_logger` | ||
| and `trace_logger` features. Below are the suggested migration paths: | ||
|
|
||
| - `env_logger`: users should use [`tracing_subscriber::fmt::Subscriber`] | ||
| or [`tracing_subscriber::fmt::Layer`] with the [`Targets`] or [`EnvFilter`] | ||
| filters instead. | ||
| - `trace_logger`: users should use the `tracing` crate's "log" feature flag instead. | ||
|
|
||
| ### Breaking Changes | ||
|
|
||
| - Remove `env_logger` feature ([#2771]) | ||
| - Remove `trace_logger` feature ([#2771]) |
There was a problem hiding this comment.
can we maybe mention somewhere in here that env_logger was removed as part of mitigation for a RustSec advisory?
tracing-log/CHANGELOG.md
Outdated
| - `env_logger`: users should use [`tracing_subscriber::fmt::Subscriber`] | ||
| or [`tracing_subscriber::fmt::Layer`] with the [`Targets`] or [`EnvFilter`] | ||
| filters instead. | ||
| - `trace_logger`: users should use the `tracing` crate's "log" feature flag instead. |
There was a problem hiding this comment.
can we link to the tracing crate docs discussing this feature?
| @@ -1,3 +1,24 @@ | |||
| # 0.2.0 (October 23rd, 2023) | |||
|
|
|||
| This release contains two breaking changes: the removal of the `env_logger` | |||
There was a problem hiding this comment.
should we maybe mention that they were already deprecated in 0.1.x?
Co-authored-by: Eliza Weisman <eliza@buoyant.io>
|
will address the nits after dinner, if that's okay! |
i just went ahead and did it, hope that's okay! |
hawkw
approved these changes
Oct 24, 2023
hawkw
pushed a commit
that referenced
this pull request
Nov 13, 2023
# 0.3.18 (November 13, 2023) This release of `tracing-subscriber` adds support for the [`NO_COLOR`] environment variable (an informal standard to disable emitting ANSI color escape codes) in `fmt::Layer`, reintroduces support for the [`chrono`] crate, and increases the minimum supported Rust version (MSRV) to Rust 1.63.0. It also introduces several minor API improvements. ### Added - **chrono**: Add [`chrono`] implementations of `FormatTime` ([#2690]) - **subscriber**: Add support for the [`NO_COLOR`] environment variable in `fmt::Layer` ([#2647]) - **fmt**: make `format::Writer::new()` public ([#2680]) - **filter**: Implement `layer::Filter` for `Option<Filter>` ([#2407]) ### Changed - **log**: bump version of `tracing-log` to 0.2 ([#2772]) - Increased minimum supported Rust version (MSRV) to 1.63.0+. [`chrono`]: https://github.com/chronotope/chrono [`NO_COLOR`]: https://no-color.org/ [#2690]: #2690 [#2647]: #2647 [#2680]: #2680 [#2407]: #2407 [#2772]: #2772 Thanks to @shayne-fletcher, @dmlary, @kaifastromai, and @jsgf for contributing!
Open
kaffarell
pushed a commit
to kaffarell/tracing
that referenced
this pull request
Feb 14, 2024
# 0.3.18 (November 13, 2023) This release of `tracing-subscriber` adds support for the [`NO_COLOR`] environment variable (an informal standard to disable emitting ANSI color escape codes) in `fmt::Layer`, reintroduces support for the [`chrono`] crate, and increases the minimum supported Rust version (MSRV) to Rust 1.63.0. It also introduces several minor API improvements. ### Added - **chrono**: Add [`chrono`] implementations of `FormatTime` ([tokio-rs#2690]) - **subscriber**: Add support for the [`NO_COLOR`] environment variable in `fmt::Layer` ([tokio-rs#2647]) - **fmt**: make `format::Writer::new()` public ([tokio-rs#2680]) - **filter**: Implement `layer::Filter` for `Option<Filter>` ([tokio-rs#2407]) ### Changed - **log**: bump version of `tracing-log` to 0.2 ([tokio-rs#2772]) - Increased minimum supported Rust version (MSRV) to 1.63.0+. [`chrono`]: https://github.com/chronotope/chrono [`NO_COLOR`]: https://no-color.org/ [tokio-rs#2690]: tokio-rs#2690 [tokio-rs#2647]: tokio-rs#2647 [tokio-rs#2680]: tokio-rs#2680 [tokio-rs#2407]: tokio-rs#2407 [tokio-rs#2772]: tokio-rs#2772 Thanks to @shayne-fletcher, @dmlary, @kaifastromai, and @jsgf for contributing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch prepares a release of
tracing-log 0.2.0. The sole breaking changeis the removal of the
env_loggerfeature. Please refer to #2771 and #2750for the context behind this decision.
(Note that this branch depends on #2770 and #2771. I will rebase this branch to
catch changes that exist on v0.1.x when those branches land.)