log: remove env_logger feature and usage
#2771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkw
reviewed
Oct 23, 2023
tracing-log/src/lib.rs
Outdated
Comment on lines
70
to
71
| //! * `trace-logger`: enables an experimental `log` subscriber, deprecated since | ||
| //! version 0.1.1. |
There was a problem hiding this comment.
let's also remove this before shipping an 0.2.0? i'm fine with doing that in this PR, or in a separate one, up to you.
Oh, you're right. Let me get on that. |
hawkw
approved these changes
Oct 24, 2023
hawkw
reviewed
Oct 24, 2023
Comment on lines
-146
to
-147
| #[cfg(feature = "trace-logger")] | ||
| #[cfg_attr(docsrs, doc(cfg(feature = "trace-logger")))] |
There was a problem hiding this comment.
since this module had a feature flag, can we also remove the feature flag from the Cargo.toml?
There was a problem hiding this comment.
whoops, sorry—I had completely missed that.
when we removed the `trace_logger` module, we didn't remove the attributes on the module declaration, and they accidentally ended up applying to the `log` crate reexport instead. whoops.
hawkw
pushed a commit
that referenced
this pull request
Oct 24, 2023
# 0.2.0 (October 24th, 2023) This release contains two breaking changes: the removal of the `env_logger` and `trace_logger` features. Below are the suggested migration paths: - `env_logger`: users should use [`tracing_subscriber::fmt::Subscriber`] or [`tracing_subscriber::fmt::Layer`] with the [`Targets`] or [`EnvFilter`] filters instead. - `trace_logger`: users should use the `tracing` crate's ["log" feature flag][log-feature] instead. ### Breaking Changes - Remove deprecated `env_logger` feature. This removes the dependency on the unmaintained `atty` crate, resolving the security advisory [GHSA-g98v-hv3f-hcfr]/[RUSTSEC-2021-0145]. ([#2771]) - Remove deprecated `trace_logger` feature. ([#2771]) [#2771]: #2771 [`tracing_subscriber::fmt::Subscriber`]: https://docs.rs/tracing-subscriber/0.3.17/tracing_subscriber/fmt/struct.Subscriber.html [`tracing_subscriber::fmt::Layer`]: https://docs.rs/tracing-subscriber/0.3.17/tracing_subscriber/fmt/struct.Layer.html [`Targets`]: https://docs.rs/tracing-subscriber/0.3.17/tracing_subscriber/filter/targets/struct.Targets.html [`EnvFilter`]: https://docs.rs/tracing-subscriber/0.3.17/tracing_subscriber/filter/struct.EnvFilter.html [log-feature]: https://docs.rs/tracing/latest/tracing/#emitting-log-records [GHSA-g98v-hv3f-hcfr]: GHSA-g98v-hv3f-hcfr [RUSTSEC-2021-0145]: https://rustsec.org/advisories/RUSTSEC-2021-0145.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the
env_loggerfeature in order to address GHSA-g98v-hv3f-hcfr.For additional details on the approach, please refer to #2750. Note that this
PR depends on #2770, so this PR will temporarily have more commits
than intended.