Support ephemeral port assignments on bind #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcches
approved these changes
Mar 28, 2023
src/net/tcp/listener.rs
Outdated
Comment on lines
27
to
29
| /// | ||
| /// Only 0.0.0.0 is currently supported. | ||
| /// When the port is unspecified (0), an ephemeral port number is generated. |
There was a problem hiding this comment.
Suggested change
| /// | |
| /// Only 0.0.0.0 is currently supported. | |
| /// When the port is unspecified (0), an ephemeral port number is generated. | |
| /// Binding with a port number of 0 will request that the OS assigns a port | |
| /// to this listener. The port allocated can be queried via the `local_addr` | |
| /// method. | |
| /// | |
| /// Only 0.0.0.0 is currently supported. |
src/net/udp.rs
Outdated
| @@ -94,6 +94,7 @@ impl UdpSocket { | |||
| /// provided. | |||
| /// | |||
| /// Only 0.0.0.0 is currently supported. | |||
| /// When the port is unspecified (0), an ephemeral port number is generated. | |||
There was a problem hiding this comment.
Let's update this one to public docs as well:
/// This function will create a new UDP socket and attempt to bind it to
/// the `addr` provided.
///
/// Binding with a port number of 0 will request that the OS assigns a port
/// to this listener. The port allocated can be queried via the `local_addr`
/// method.
mcches
approved these changes
Mar 30, 2023
mcches
reviewed
Mar 30, 2023
mcches
reviewed
Mar 30, 2023
mcches
reviewed
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#104