Add support for loopback #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes adds UDP and TCP support for loopback. Packets sent over loopback do not flow through the topology, instead they are sent directly from the host back to itself - somewhat modeling how the real world works. The affects of this implementation are that network manipulation APIs do not work on loopback traffic. However, this approach gets incrementally closer towards full loopback support and unblocks most use cases.
This change adds UDP and TCP support for loopback. Packets sent over loopback do not flow through the topology, instead they are sent directly from the host back to itself - somewhat modeling how the real world works. The side effect of this implementation is that network manipulation APIs do not work on loopback traffic. However, this approach gets incrementally closer towards full loopback support and unblocks most use cases.
mcches
approved these changes
May 23, 2023
Comment on lines
-46
to
-47
| // Unspecified -> host's IP | ||
| addr.set_ip(host.addr); |
Co-authored-by: Brett McChesney <39924297+mcches@users.noreply.github.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes adds UDP and TCP support for loopback. Packets sent over loopback
do not flow through the topology, instead they are sent directly from the host
back to itself - somewhat modeling how the real world works. The affects of
this implementation are that network manipulation APIs do not work on loopback
traffic. However, this approach gets incrementally closer towards full loopback
support and unblocks most use cases.
The implementation is a bit of hack. I think where we want to get to is full
support for multiple interfaces. For example, hosts should be allowed to have
both an v4 and v6 ip addr. This will require a bit of a lift due to how hosts
are identified by an IP address.