-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracing improvments #124
Tracing improvments #124
Conversation
Generally speaking, you shouldn't need to pass a |
Tagging #49. |
@davidbarsky since spans are entered 3 times pre tick, it seems wasteful to me to create the span inline, |
Creating spans and events is generally pretty cheap, especially if they are disabled and filtered out. I think keeping an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple minor comments. This will be really nice for debugging.
Some improvements to tracing with turmoil:
Rt
andHost
to cover all codepaths that may emit eventssrc
,dst
, ...,msg
)src
now always represents the source of the packet, the tracing record was about (src
of SYN is client,src
of SYN-ACK is server)