Fix duplicate FIN in the drop glue #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the stream is shutdown manually it sends a FIN on the write half, however we don't check the state in the drop implementation, which led to a duplicate FIN being sent. To fix, `is_shutdown` is checked before sending the FIN.
|
Verified 2x of these before, only one after the change. 2023-10-20T16:36:05.204647Z TRACE node{name="client"}: turmoil: Send src=192.168.0.2:49152 dst=192.168.0.1:1738 protocol=TCP FIN |
tereshch-aws
approved these changes
Oct 20, 2023
marcbowes
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the stream is shutdown manually it sends a FIN on the write half,
however we don't check the state in the drop implementation, which led
to a duplicate FIN being sent.
To fix,
is_shutdownis checked before sending the FIN.