Add network topology introspection #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sim now supports iterating each host pair's network link, as well as each message that is currently "in flight" on the network. Link and message metadata is exposed. We can also now force delivery of messages. In combination with the step capabilities that were recently added we now have the ability to run more complex test scenarios.
mh32
approved these changes
Jan 23, 2023
| Syn(Syn), | ||
| Data(u64, Bytes), | ||
| Fin(u64), | ||
| Rst, | ||
| } | ||
|
|
||
| #[derive(Debug)] | ||
| pub(crate) struct Syn { | ||
| pub struct Syn { |
There was a problem hiding this comment.
Is there any reason you prefer pub(crate) to pub with visibility limited to crate at the module declaration?
There was a problem hiding this comment.
No reason, just started out this way. We could go back and and fix this at some point for the internals.
| @@ -192,6 +204,13 @@ impl<'a> Sim<'a> { | |||
| world.topology.set_link_fail_rate(a, b, value); | |||
| } | |||
|
|
|||
| /// Access a [`LinksIter`] to introspect inflight messages between hosts. | |||
| pub fn links(&self, f: impl FnOnce(LinksIter)) { | |||
There was a problem hiding this comment.
Did you consider returning an iterator? Seems slightly more idiomatic
There was a problem hiding this comment.
It would certainly be nicer, but I don't believe we can since we need to borrow the world's ref cell.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sim now supports iterating each host pair's network link, as well
as each message that is currently "in flight" on the network.
Link and message metadata is exposed. We can also now force delivery
of messages.
In combination with the step capabilities that were recently added we
now have the ability to run more complex test scenarios.