Push '.' to @INC when custom builder is used #216
Conversation
@inc does not contain current directory from Perl 5.25.9.
|
I have confirmed that with this change, |
| @@ -75,6 +75,9 @@ use strict; | |||
| use warnings; | |||
| use utf8; | |||
|
|
|||
| ? if ( $project->build_class ne 'Module::Build' ) { | |||
There was a problem hiding this comment.
if minil.toml is
name = "Foo"
module_maker = "ModuleBuild"
[XSUtil]
needs_compiler_c99 = 1
then build_class is Module::Build::XSUtil. I think we can exclude 'Module::Build::XSUtil' too.
|
I don't think this will fix it. I think this is going to require PERL_USE_UNSAFE_INC but I'll need to test it later. If I could see a Build.PL generated from this, I could tell you if it works. I'll see if I can figure out how to re-generate the one for Mouse. |
|
Thanks for comments. I'll see them later. |
|
LGTM @toddr Could you test this please? |
|
@skaji Minilla now builds the correct Build.PL for Mouse. Once this is merged and released, I'll let the 5 dists that need a new Build.PL to update Minilla and release. |
|
Thanks for reviewing. I have merged. |
Changelog diff is:
diff --git a/Changes b/Changes
index 8a31200..c3261a5 100644
--- a/Changes
+++ b/Changes
@@ -1,6 +1,8 @@
Revision history for Perl extension Minilla
{{$NEXT}}
+
+v3.0.10 2017-02-20T16:30:43Z
- Set '.' to @inc when using custom builder for newer Perl(#216)
v3.0.9 2017-01-12T04:30:41Z
Changelog diff is:
diff --git a/Changes b/Changes
index c3261a5..8e09edd 100644
--- a/Changes
+++ b/Changes
@@ -2,6 +2,10 @@ Revision history for Perl extension Minilla
{{$NEXT}}
+v3.0.11 2017-05-22T10:22:00Z
+ - Fix tests for no-dot-in-inc (eserte #220, #221)
+ - Now Minilla requires perl 5.10.1+ (#222)
+
v3.0.10 2017-02-20T16:30:43Z
- Set '.' to @inc when using custom builder for newer Perl(#216)
@INCdoes not contain current directory from Perl 5.25.9.This is related to #215.