#165368514 Implement LFA feedback on returning appropriate status codes from API's #44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactors controllers to return the appropriate HTTP responses for new transactions and error handling
Description of Task to be completed?
How should this be manually tested?
After cloning the repo,
cd
into it and do the following:Using Postman:
Visit the sign in route created in #29 at
localhost:5000/api/v1/auth/signin
without registering. This should return an error with a status code of 404Any background context you want to provide?
N/a
What are the relevant pivotal tracker stories?
#165368514
Screenshots (if appropriate)