Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#165368514 Implement LFA feedback on returning appropriate status codes from API's #44

Merged
merged 2 commits into from
Apr 16, 2019

Conversation

tolulope-od
Copy link
Owner

What does this PR do?

Refactors controllers to return the appropriate HTTP responses for new transactions and error handling

Description of Task to be completed?

  • Return appropriate error code when a user is not found
  • Return appropriate error code when a new transaction (debit or credit) is carried out
  • Fix implicit return error on authorization middleware and return the appropriate response code

How should this be manually tested?

After cloning the repo, cd into it and do the following:

# install dependencies
npm install

# run unit tests
npm test

Using Postman:
Visit the sign in route created in #29 at localhost:5000/api/v1/auth/signin without registering. This should return an error with a status code of 404

Any background context you want to provide?

N/a

What are the relevant pivotal tracker stories?

#165368514

Screenshots (if appropriate)

Implement LFA feedback on returning appropriate error status code from the server

[Finishes #165368514]
Fix issue where coverage report isnt sent to coveralls after build succeeds

[Finishes #165385122]
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 96.305% when pulling 9ca4760 on ch-implement-status-codes-feedback-165368514 into b34e41b on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 96.305% when pulling 9ca4760 on ch-implement-status-codes-feedback-165368514 into b34e41b on develop.

@tolulope-od tolulope-od merged commit bd30233 into develop Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants