expose unsafe methods to create and forget PushGuards #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is most useful when using a library to poke at the Rust state. The most important methods made public are `new` to create a new `PushGuard`, and `forget` to not run this `PushGuard`'s destructor. They're both unsafe because their misuse can easily cause crashes. Also expose a `size` method to access the number of elements this `PushGuard` is managing, and provide an internal-only safe version of `forget` under the assumption that consumers within this crate know what they're doing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is most useful when poking at the Lua state directly.
The most important methods made public are
newto create a newPushGuard, andforgetto not run thisPushGuard's destructor.They're both unsafe because their misuse can easily cause the Lua
stack to be out of sync with Rust
PushGuards.Also expose a
sizemethod to access the number of elements thisPushGuardis managing, and provide an internal-only safe version offorgetunder the assumption that consumers within this crate know whatthey're doing.