Problem: routing url-encoded URLs doesn't work properly #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrashk
added a commit
to sit-fyi/sit
that referenced
this pull request
Feb 22, 2018
Apparently, it is impossible to specify some more involved JMESPath expressions, for example, ones that would contain `?contains` or a slash in them. Solution: make sure both frontend use percent encoding The reason for this malfunction is that, firstly, the frontend part didn't encode the URL components being 1) sent to the server 2) updated in the location of the page. Secondly, the backend's library for handling HTTP (rouille) eagerly decoded URLs thus rendering it impossible to match on these values as `?` or `/` would trigger stops. A forked version of roulle is used now. If the [pull request](tomaka/rouille#173) will be accepted, can switch back at that time.
|
Thanks, looks good! Please also add am entry in the changelog and I'll merge. |
tomaka
approved these changes
Feb 22, 2018
The URL is being decoded before any matching is done. So, for example, `/hello/%3Fa` will not match `/hello/a` because `%3F` is already decoded to `?`. Solution: use raw URL to do the routing and decode individual parts instead.
|
Updated the changelog. |
|
@tomaka Hi Pierre, what's the ETA for the next release? I am running into vendoring/frozen builds issues packaging my app for NixOS -- I am yet to see a workaround for git-based dependencies in their process. In the meantime, the only solid way for things to work is to depend on crates.io-only packages. Hence the question about the next release! Thanks. |
|
@yrashk If you submit a PR that bumps the version in Cargo.toml and CHANGELOG, it will automatically be published once merged. |
|
Awesome, will do!
…On Mon, Mar 5, 2018, 8:46 PM Pierre Krieger ***@***.***> wrote:
@yrashk <https://github.com/yrashk> If you submit a PR that bumps the
version in Cargo.toml and CHANGELOG, it will automatically be published
once merged.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#173 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAABxOhEefQVn4GGArqldAo14JOMdVBFks5tbUG4gaJpZM4SOwzd>
.
|
yrashk
added a commit
to sit-fyi/issue-tracking
that referenced
this pull request
Apr 9, 2018
Apparently, it is impossible to specify some more involved JMESPath expressions, for example, ones that would contain `?contains` or a slash in them. Solution: make sure both frontend use percent encoding The reason for this malfunction is that, firstly, the frontend part didn't encode the URL components being 1) sent to the server 2) updated in the location of the page. Secondly, the backend's library for handling HTTP (rouille) eagerly decoded URLs thus rendering it impossible to match on these values as `?` or `/` would trigger stops. A forked version of roulle is used now. If the [pull request](tomaka/rouille#173) will be accepted, can switch back at that time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The URL is being decoded before any matching is done.
So, for example,
/hello/%3Fawill not match/hello/abecause%3Fis already decoded to
?.Solution: use raw URL to do the routing and decode individual parts
instead.