Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ATTACH statement #71

Merged
merged 2 commits into from
Mar 9, 2020
Merged

Implement ATTACH statement #71

merged 2 commits into from
Mar 9, 2020

Conversation

SUMUKHA-PK
Copy link
Collaborator

This PR completes the implementation of ATTACH statement (https://sqlite.org/lang_attach.html), and completes a part of #66

@tsatke tsatke changed the title This commit adds tests and implementation of the ATTACH statement for the parser implement ATTACH statement Mar 9, 2020
@github-actions
Copy link

github-actions bot commented Mar 9, 2020

⚠ staticcheck Failed

internal/parser/parser_test.go:205:6: func debugPrintTokenData is unused (U1000)

Checks Document

@SUMUKHA-PK SUMUKHA-PK changed the title implement ATTACH statement Implement ATTACH statement Mar 9, 2020
@SUMUKHA-PK SUMUKHA-PK requested a review from tsatke March 9, 2020 11:08
@tsatke tsatke merged commit d3d6ddf into master Mar 9, 2020
@tsatke tsatke deleted the attach-stmt branch March 9, 2020 11:14
@tsatke tsatke added component/parser This is regarding the SQL parser feature New feature or enhancement labels Mar 9, 2020
@tsatke tsatke added this to the v0.0.1 milestone Mar 9, 2020
@tsatke tsatke mentioned this pull request Mar 9, 2020
Closed
59 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsatke tsatke tsatke approved these changes

Assignees
No one assigned
Labels
component/parser This is regarding the SQL parser feature New feature or enhancement
Projects
None yet
Milestone
v0.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@SUMUKHA-PK @tsatke