Implements ANALYZE stmt #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⚠ staticcheck Failed |
tsatke
suggested changes
Mar 9, 2020
| stmt.Analyze = next | ||
| p.consumeToken() | ||
|
|
||
| // optionalLookahead is used again because, ANALYZE alone is a valid string |
There was a problem hiding this comment.
why again?
Suggested change
| // optionalLookahead is used again because, ANALYZE alone is a valid string | |
| // optionalLookahead is used, because ANALYZE alone is a valid statement |
There was a problem hiding this comment.
Previous rule had it too. Will change
Comment on lines
783
to
784
| next, _ = p.optionalLookahead(r) | ||
| if next.Type() == token.EOF { |
There was a problem hiding this comment.
Suggested change
| next, _ = p.optionalLookahead(r) | |
| if next.Type() == token.EOF { | |
| next, ok = p.optionalLookahead(r) | |
| if !ok || next.Type() == token.EOF { |
Comment on lines
797
to
798
| period, _ := p.optionalLookahead(r) | ||
| if period.Type() == token.EOF { |
There was a problem hiding this comment.
Suggested change
| period, _ := p.optionalLookahead(r) | |
| if period.Type() == token.EOF { | |
| period, ok := p.optionalLookahead(r) | |
| if !ok || period.Type() == token.EOF { |
tsatke
approved these changes
Mar 9, 2020
59 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completes the implementation of ANALYZE stmt (https://sqlite.org/lang_analyze.html) and is a part of #66