-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test failures on node v14-v16 #395
Comments
This fixes a failing socket cleanup test by destroying the request on error. This test did not fail on macOS. Closes tomas#395
I can't tell from the git commit history why this was commented out, but uncommenting this line in the test fixes it: stream.pipeline(resp, writable, function(err) {
err.code.should.eql('ERR_STREAM_PREMATURE_CLOSE')
// if (err) resp.request.destroy();
}); @tomas, any insight on that? I'll put up a PR in case that's the right fix. If it's not... I'll need you to figure it out. I'm out of ideas. |
I should have mentioned, this failure was on node v16. When I run tests on macOS with node v16 or v14, I get this failure, too. So it's not specific to Linux after all. |
This fixes a failing socket cleanup test by destroying the request on error. This test did not fail on macOS. Closes tomas#395
This fixes a failing socket cleanup test by destroying the request on error. This test did not fail on node v17. Closes tomas#395
This fixes a failing socket cleanup test by destroying the request on error. This test did not fail on node v17. Closes tomas#395
I get the following test failure on Linux after fixing the macOS failures in #393 with PR #394
The text was updated successfully, but these errors were encountered: