Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add follow_if_different_location config #300

Merged

Conversation

laurent35240
Copy link

I added follow_if_different_location in order to be able to decide if we want to process redirect if location in the same.

We have example of websites redirecting with same location but with different cookies and so not ending with a redirection loop. So in this case we do not want to stop redirections.

…direction even if it points to same location
@tomas
Copy link
Owner

tomas commented Mar 17, 2020

Looks good, thanks. I'm thinking it's clearer to say follow_if_same_location (default: false) than the opposite. What do you think?

@laurent35240
Copy link
Author

I chose follow_if_different_location in order to have consistent explanation of configuration in README.
To always have something like When true, Needle will only follow redirects that...

But if you really prefer follow_if_same_location, sure I can change it.

Let me know

@laurent35240
Copy link
Author

laurent35240 commented Apr 2, 2020

Hi

@tomas Any chance that this pull request will be merged soon?

@tomas
Copy link
Owner

tomas commented Apr 2, 2020

If you can change the param to follow_if_same_location I'll merge it. It seems to make more sense considering the other options:

image

@laurent35240
Copy link
Author

OK it is changed

@tomas tomas merged commit 4ea8b88 into tomas:master Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants