Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misleading event in documentation #315

Merged
merged 1 commit into from
Aug 24, 2021
Merged

misleading event in documentation #315

merged 1 commit into from
Aug 24, 2021

Conversation

JiPaix
Copy link
Contributor

@JiPaix JiPaix commented May 2, 2020 •
edited
Loading

fs.createWriteStream doesn't fire a 'done' event.

  • changed 'done' to 'close'
  • added 2 examples to avoid confusion

fix #313

@JiPaix JiPaix changed the title wrong event in documentation misleading event in documentation May 2, 2020
@JiPaix JiPaix closed this May 2, 2020
@JiPaix JiPaix reopened this May 2, 2020
@tomas tomas merged commit c2fd1f8 into tomas:master Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

done event never getting fired!!!
2 participants
@JiPaix @tomas