-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
146 standardizing embed formats #148
146 standardizing embed formats #148
Conversation
This avoids the promises returned from the async(instance). Also keeps it simpler to read.
Need more formatting for the content within codeblocks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, just one thing to patch up and one to remove. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Just needs a few more adjustments.
@RazCrimson great job! Thanks for sticking with this. |
Fixes #146 and possibly #128 . Take a look and tell me if I need to change something.