Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

146 standardizing embed formats #148

Merged
merged 12 commits into from
Oct 25, 2020
Merged

146 standardizing embed formats #148

merged 12 commits into from
Oct 25, 2020

Conversation

RazCrimson
Copy link
Contributor

Fixes #146 and possibly #128 . Take a look and tell me if I need to change something.

Copy link
Collaborator

@rgroves rgroves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, just one thing to patch up and one to remove. Thanks!

src/commands/list.js Show resolved Hide resolved
src/utils/utils.js Outdated Show resolved Hide resolved
@RazCrimson RazCrimson marked this pull request as ready for review October 24, 2020 22:59
Copy link
Collaborator

@rgroves rgroves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Just needs a few more adjustments.

src/commands/add.js Outdated Show resolved Hide resolved
src/commands/demote.js Outdated Show resolved Hide resolved
src/commands/promote.js Outdated Show resolved Hide resolved
src/commands/promote.js Outdated Show resolved Hide resolved
@rgroves
Copy link
Collaborator

rgroves commented Oct 25, 2020

@RazCrimson great job! Thanks for sticking with this.

@rgroves rgroves merged commit 85007bc into tomassirio:master Oct 25, 2020
@RazCrimson RazCrimson deleted the 146-Standardizing-embed-formats branch October 30, 2020 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Standardizing Embed Formats
2 participants