Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] The embedded messages look kind of sloppy #128

Closed
tomassirio opened this issue Oct 18, 2020 · 8 comments
Closed

[FEATURE] The embedded messages look kind of sloppy #128

tomassirio opened this issue Oct 18, 2020 · 8 comments

Comments

@tomassirio
Copy link
Owner

image

That's the list command right now. Every notification on the bot shows a similar message. It would look really nice if we could get a message like the queue on groovy

image

Example:

  1. <list element>                        <author>
    
  2. <list element>                        <author>
    

.....
n)

@Remakh
Copy link

Remakh commented Oct 19, 2020

Could I do this?

@tomassirio
Copy link
Owner Author

Sure! I'll assign it to you. If you want to keep in contact, we have a discord server were we discuss this and the other bots optimization

@Remakh
Copy link

Remakh commented Oct 19, 2020

Sure thanks very much!

@rgroves
Copy link
Collaborator

rgroves commented Oct 23, 2020

Hi @Remakh, how is the work on this issue going? Asking because another contributor wants to make some additions (See Issue #146) that will probably collide with what you're working on. If you're close to finishing, we may hold on that Issue until you can get a PR in. Otherwise, it will be a race to finish, and whoever gets in last will likely have to deal with managing merge conflicts or just reapplying their work over the latest code.

@Remakh
Copy link

Remakh commented Oct 23, 2020

Sorry I've had a lot of coursework and team projects recently, and still do if I'm being honest. If someone else would like to start and possibly finish it before me that's fine.

@rgroves
Copy link
Collaborator

rgroves commented Oct 23, 2020

Ok, thanks for the update.

@rgroves
Copy link
Collaborator

rgroves commented Oct 26, 2020

This was partially addressed by PR #148.
PR #149 should close this out once it's ready to be merged.

rgroves added a commit that referenced this issue Oct 30, 2020
Improves the look of bot messages.
This work was related to Issue #128. More work may be needed, see issue for details.
@rgroves
Copy link
Collaborator

rgroves commented Oct 30, 2020

I'm going to close this out since PR #149 was completed and merged. If further improvements to the bot messages are required, we can address them as a new issue.

@rgroves rgroves closed this as completed Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants