Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for abstract traits and mocking of trait-methods #32

Merged
merged 5 commits into from
Aug 14, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "tomaszdurka/mocka",
"license": "MIT",
"require": {
"tomaszdurka/codegenerator": "~0.4.2"
"tomaszdurka/codegenerator": "~0.5.0"
},
"require-dev": {
"phpunit/phpunit": "~3.7.10",
Expand Down
27 changes: 22 additions & 5 deletions source/Mocka/AbstractClassTrait.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public function __clone() {

/**
* @param string $name
* @param array $arguments
* @param array $arguments
* @return mixed
*/
public function __call($name, $arguments) {
Expand Down Expand Up @@ -47,7 +47,7 @@ public function unmockMethod($name) {

/**
* @param string $name
* @param array $arguments
* @param array $arguments
* @throws Exception
* @return mixed
*/
Expand Down Expand Up @@ -84,7 +84,7 @@ private static function _getClassMethodMockCollectionStatic() {

/**
* @param string $name
* @param array $arguments
* @param array $arguments
* @return mixed
*/
private function _callMethod($name, array $arguments) {
Expand All @@ -94,6 +94,9 @@ private function _callMethod($name, array $arguments) {
if ($this->_getClassMethodMockCollection()->hasMockedMethod($name)) {
return $this->_getClassMethodMockCollection()->callMockedMethod($name, $arguments);
}
if (static::_hasTraitMethod($name)) {
return call_user_func_array([$this, "_mockaTraitAlias_{$name}"], $arguments);
}
if (static::_hasParentMethod($name)) {
return call_user_func_array(array('parent', $name), $arguments);
}
Expand All @@ -120,9 +123,23 @@ private static function _hasParentMethod($name) {
return true;
}

/**
* @param $name
* @return bool
*/
private static function _hasTraitMethod($name) {
$mockClass = static::_getMockClass();
$reflectionsClass = new \ReflectionClass($mockClass->getParentClassName());
foreach ($reflectionsClass->getTraits() as $reflectionTrait) {
if ($reflectionTrait->hasMethod($name)) {
return true;
}
}
}

/**
* @param string $name
* @param array $arguments
* @param array $arguments
* @return mixed
*/
public static function __callStatic($name, $arguments) {
Expand All @@ -139,7 +156,7 @@ protected static function _getMockClass() {

/**
* @param string $name
* @param array $arguments
* @param array $arguments
* @return mixed
*/
private static function _callStaticMethod($name, array $arguments) {
Expand Down
12 changes: 10 additions & 2 deletions source/Mocka/ClassAbstractMock.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

use CodeGenerator\ClassBlock;
use CodeGenerator\MethodBlock;
use CodeGenerator\TraitBlock;

class ClassAbstractMock {

Expand Down Expand Up @@ -49,9 +50,16 @@ public function generateCode() {
$class->addInterface($interface);
}
foreach ($this->_traits as $trait) {
$reflectionTrait = new \ReflectionClass($trait);
$trait = new TraitBlock($trait);
foreach ($reflectionTrait->getMethods() as $reflectionMethod) {
if (!$reflectionMethod->isAbstract()) {
$trait->addAlias($reflectionMethod->getName(), "_mockaTraitAlias_{$reflectionMethod->getName()}");
}
}
$class->addUse($trait);
}
$class->addUse('\Mocka\AbstractClassTrait');
$class->addUse(new TraitBlock('\Mocka\AbstractClassTrait'));

$mockableMethods = $this->_getMockableMethods();
foreach ($mockableMethods as $reflectionMethod) {
Expand Down Expand Up @@ -109,7 +117,7 @@ protected function _getReservedKeywords() {
protected function _getMockableMethods() {
/** @var \ReflectionMethod[] $methods */
$methods = array();
$interfaces = $this->_interfaces;
$interfaces = array_merge($this->_interfaces, $this->_traits);
if ($this->_parentClassName) {
$interfaces[] = $this->_parentClassName;
}
Expand Down
3 changes: 2 additions & 1 deletion source/Mocka/ClassMock.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

use CodeGenerator\ClassBlock;
use CodeGenerator\PropertyBlock;
use CodeGenerator\TraitBlock;

class ClassMock {

Expand Down Expand Up @@ -98,7 +99,7 @@ public function generateCode() {
if ($this->_parentClassName) {
$class->setParentClassName($this->_parentClassName);
}
$class->addUse('\Mocka\ClassTrait');
$class->addUse(new TraitBlock('\Mocka\ClassTrait'));
return $class->dump();
}

Expand Down
6 changes: 6 additions & 0 deletions tests/mocks/TraitMock.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,13 @@

trait TraitMock {

abstract function abstractTraitMethod();

public function traitMethod() {

}

public function bar () {
return 'traitbar';
}
}
17 changes: 16 additions & 1 deletion tests/source/Mocka/ClassAbstractMockTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,25 @@ public function testGenerateCodeTrait() {
$expectedMockCode = <<<EOD
class $className {

use $traitName;
use $traitName {
traitMethod as _mockaTraitAlias_traitMethod;
bar as _mockaTraitAlias_bar;
}

use \Mocka\AbstractClassTrait;

public function abstractTraitMethod() {
return \$this->_callMethod(__FUNCTION__, func_get_args());
}

public function traitMethod() {
return \$this->_callMethod(__FUNCTION__, func_get_args());
}

public function bar() {
return \$this->_callMethod(__FUNCTION__, func_get_args());
}

public function __construct() {
return \$this->_callMethod(__FUNCTION__, func_get_args());
}
Expand Down
11 changes: 11 additions & 0 deletions tests/source/Mocka/ClassMockTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,17 @@ public function testMockMethodFinal() {
$classMock->mockMethod('zoo');
}

public function testMockMethodFromTrait() {
$classMock = new ClassMock(null, '\\MockaMocks\\AbstractClass', null, ['\\MockaMocks\\TraitMock']);

/** @var AbstractClassTrait|AbstractClass $object */
$object = $classMock->newInstanceWithoutConstructor();
$this->assertSame('traitbar', $object->bar());

$classMock->mockMethod('bar');
$this->assertSame(null, $object->bar());
}

public function testMockStaticMethod() {
$classMock = new ClassMock(null, '\\MockaMocks\\AbstractClass');
/** @var AbstractClass $className */
Expand Down