feat(preventDuplicates): Changed to list #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tomchentw The previous pull request helps us avoid the duplicate messages. Kindly approve this pull request since it completes the functionality. |
|
@RangarajKaushikSundar I'd like to invite you to be a collaborator of this project. Are you interested? |
|
@tomchentw I would be happy to. |
|
Released v2.8.0 |
|
@RangarajKaushikSundar invited! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prevent duplicates feature works by checking the previously rendered message with the current message and avoids duplicates. There is a test case which will not pass in the following situation - success('hello') --- followed by --> success('bye') --- followed by--> success('hello'). The last "hello" should not render until the previous "hello" has unmounted.
Now, the code maintains a list of messages that are currently being rendered. This makes sure that aforementioned issue doesn't happen.