Improve odometry publisher system #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shameek Ganguly <shameek@google.com>
Signed-off-by: Shameek Ganguly <shameek@google.com>
Signed-off-by: Shameek Ganguly <shameek@google.com>
azeey
reviewed
Aug 23, 2024
| @@ -121,6 +134,12 @@ OdometryPublisher::OdometryPublisher() | |||
| { | |||
| std::get<2>(this->dataPtr->linearMean).SetWindowSize(10); | |||
| std::get<2>(this->dataPtr->linearMean).Clear(); | |||
|
|
|||
There was a problem hiding this comment.
Do we need to add back std::get<2>(this->dataPtr->angularMean).SetWindowSize(10); and std::get<2>(this->dataPtr->angularMean).Clear(); for the 2D case?
There was a problem hiding this comment.
You're right, added back the rolling mean for Z-axis angular velocity in 95d88f8
I also removed the redundant Clear calls as the objects don't have any value at this point.
…tatements Signed-off-by: Shameek Ganguly <shameek@google.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestions to address my review comments in gazebosim#2348