-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dotenv support #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks! Apart from the .gitignore thing - would be good to get that confirmed.
.gitignore
Outdated
|
||
cache/ | ||
index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately we can't .gitignore index.html and prompt.txt because Google Cloud Run doesn't upload files which are matched by .gitignore. At least that's my experience - I can't find a reference to this behaviour!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL! will amend
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://cloud.google.com/sdk/gcloud/reference/topic/gcloudignore mentions
The default content of the generated
.gcloudignore
file, which can be overriden with--ignore-file
, is as follows:.gcloudignore .git .gitignore
...
In order to ignore files specified in the gitignore file, there is a special comment syntax:
#!include:.gitignore
So you are right
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking out loud.. given the fact nldb
is intended to be installed as a package/dependency, it should not contain this .gitignore
🤔
Thanks @zerolab! |
This PR adds python-dotenv as a dependency to support
.env
files as I consistently fail to runexport ...