Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't block on API calls #4

Merged
merged 4 commits into from
May 18, 2023
Merged

Don't block on API calls #4

merged 4 commits into from
May 18, 2023

Conversation

tomdyson
Copy link
Owner

And remove lru_cache decorators.

@tomdyson tomdyson requested a review from zerolab May 17, 2023 16:04
zerolab
zerolab requested changes May 17, 2023
View reviewed changes
Copy link
Collaborator

@zerolab zerolab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick first pass check and left a couple of notes. Will check and test further later

nldb/api.py Show resolved Hide resolved
nldb/core.py Show resolved Hide resolved
nldb/core.py Show resolved Hide resolved
tomdyson and others added 2 commits May 18, 2023 10:23
@tomdyson @zerolab
Add OPENAPI_KEY explicitly
88e8083 
Co-authored-by: Dan Braghis <dan@zerolab.org>
@tomdyson
Import OA key
4069d3b
@tomdyson tomdyson merged commit 2325a80 into main May 18, 2023
@tomdyson tomdyson deleted the asyncify branch May 18, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zerolab zerolab zerolab requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tomdyson @zerolab