Allow passing kwargs to paramiko client #564
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently it's impossible to pass a socks proxy to a ParamikoMachine, even though paramiko supports that. By chaining kwargs through to the paramiko client, we expose the full functionality of paramiko to the user.
|
Why did you close this? |
|
I realized there was some functionality missing that meant passing a socks proxy still wouldn't work. I can't remember what exactly it was right now because I tried about a month ago. |
|
Okay. Sorry for the delay, just now working out a few issues in the CI. |
|
No problem! Thanks for all your hard work - I love plumbum! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it's impossible to pass a socks proxy to a ParamikoMachine, even though paramiko supports that.
By chaining kwargs through to the paramiko client, we expose the full functionality of paramiko to the user.