Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent exceeding array bounds #17

Merged
merged 2 commits into from
Jun 21, 2023
Merged

prevent exceeding array bounds #17

merged 2 commits into from
Jun 21, 2023

Conversation

urbanjost
Copy link
Contributor

If I enter "fpm test" the default debug build with gfortran fails indicating variable bounds are exceeded it. This or something like it is needed to avoid exceeding array bounds. This definitely needs a review by someone more intimate with the code even though it allows "fpm test" to run and pass, but this prevents building anything dependent on the package to be build with the default fpm build so it would be great if it was resolved.

Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks for sharing.

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Patch coverage: 85.71% and project coverage change: +0.28 🎉

Comparison is base (4c27c8c) 34.63% compared to head (d41e0f6) 34.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
+ Coverage   34.63%   34.91%   +0.28%     
==========================================
  Files           6        6              
  Lines         589      590       +1     
  Branches      270      273       +3     
==========================================
+ Hits          204      206       +2     
  Misses        301      301              
+ Partials       84       83       -1     
Impacted Files Coverage Δ
src/jonquil/lexer.f90 61.79% <85.71%> (+0.78%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/jonquil/lexer.f90 Outdated Show resolved Hide resolved
@awvwgk awvwgk merged commit 4fbd4cf into toml-f:main Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants