Use consistent representation for infinity #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
arp242
added a commit
to BurntSushi/toml
that referenced
this pull request
Oct 10, 2023
Doesn't really matter for the toml-test test runner, but we use toml-test-decoder for generating tests, and "Inf" with capital was causing issues for some: toml-lang/toml-test#143
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
valid/spec/float-2.json, which is new in toml-test 1.4.0, caused issues with my test generator because it used"Inf"to represent the valueinfinitywhereas all other valid tests follow the TOML representation and use"inf". This PR changes the test to be consistent with all the others.