set_dotted(true) on InlineTable doesn't work as expected

[ordian]

use toml_edit::*;

fn main() {
    let mut d = Document::new();
    d["nixpkgs"] = table();
    d["nixpkgs"]["src"]["git"] = value("https://git");
    d["nixpkgs"]["src"].as_inline_table_mut().unwrap().set_dotted(true);
    println!("{}", d);
}

prints

[nixpkgs]
src = { git = "https://git"}

[ordian]

Thinking about this, what's the difference between dotted InlineTable and dotted Table?

[steveej]

i don't feel confident that i can help clear up the definitions, but i'd like to make my expectations explicit:

[nixpkgs]
src.git = "https://git"

i'm also wondering which table is considered dotted here 🤔 it seems to be a property of the keys in the nixpkgs table rather than in the src table.

[ordian]

[nixpkgs]
src.git = "https://git"

This is the expected output. And this code works:

use toml_edit::*;

fn main() {
    let mut d = Document::new();
    d["nixpkgs"] = table();
    
    d["nixpkgs"]["src"] = table();
    d["nixpkgs"]["src"].as_table_mut().unwrap().set_dotted(true);
    d["nixpkgs"]["src"]["git"] = value("https://github.com/nixos/nixpkgs");

    println!("{}", d);
}

[ordian]

i'm also wondering which table is considered dotted here thinking it seems to be a property of the keys in the nixpkgs table rather than in the src table.

This is a TOML property, so src is a table (dotted), and git is the key of that table, see https://toml.io/en/v1.0.0 for details.

EDIT: actually TOML spec talks about dotted keys, not tables. But I in terms implementation, it might be harder to implement as a property of keys.

[epage]

Thinking about this, what's the difference between dotted InlineTable and dotted Table?

Ease of implementation :)

A dotted key in a standard table can have standard tables nested under it

[fruit]
apple.color = "red"
apple.taste.sweet = true

# [fruit.apple]  # INVALID
# [fruit.apple.taste]  # INVALID

[fruit.apple.texture]  # you can add sub-tables
smooth = true

But you can't do that with Inline Tables.

And the way the divide is currently implemented generally makes it easier to convert the data back to a string. I do have an idea that might allow us to fix this.