fix(ser): Make pretty actually pretty #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes porting tests over from `toml-rs` to ensure we match their behavior. We removed the non-pretty case and the customization since those aren't as important for our use case (cargo) and we'll want to iterate on what we want from the API. Our "pretty" is different than `toml-rs` in that we prefer `"` for strings that could be literals but don't need to be literals to avoid escaping. Note: there are some other discrepancies in our "pretty" string handling that should be looked into, like switching to tripple quotes to avoid escaping. Fixes toml-rs#192
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes porting tests over from
toml-rsto ensure we match theirbehavior. We removed the non-pretty case and the customization since
those aren't as important for our use case (cargo) and we'll want to
iterate on what we want from the API.
Our "pretty" is different than
toml-rsin that we prefer"forstrings that could be literals but don't need to be literals to avoid
escaping.
Note: there are some other discrepancies in our "pretty" string handling
that should be looked into, like switching to tripple quotes to avoid
escaping.
Fixes #192