-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(edit): Expose ImDocument
, an Immutable Document
#698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial inspiration for
ImDocument
is that you can parse to it to lookup spans.There is a chance for performance improvements as well because you can parse an
ImDocument
from a borrowed type theDeserializer
s are updated to take advantage of that.Potential future improvements include
&ImDocument
so you don't have to clone the document to both deserialize and look up spans for richer errorsValue
doesn't support borrowed data (and switching to owned). We'd either have to changeValue
or check if a string is equal to the substr the span points to and then deserialize as a borrowed value.With this, I wonder if we should transition
Document
to beingMutDocument
, andImDocument
to beingDocument
Compatibility:
toml_edit::de::Deserializer::new
is deprecatedCompatibility:
toml_edit::de::Deserializer
now has a defaulted generic parameter. Its debatable on whether that is a breaking change because it can't break builds in some corner cases. I viewed the risk low enough to go forward with it.