Skip to content
This repository has been archived by the owner on Jan 31, 2023. It is now read-only.

Error: Cannot resolve 'file' or 'directory' ../node_modules/emojione/emoji.json #34

Closed
elado opened this issue Aug 16, 2016 · 3 comments
Labels

Comments

@elado
Copy link

elado commented Aug 16, 2016

Using webpack.

This import is not standard: https://github.com/tommoor/emojione-picker/blob/master/src/picker.jsx#L4

and fails with webpack. If emojione is a dependency (and it is), it should be imported as emojione/emoji.json without node_modules.

I changed it locally and it it indeed loads the json, however there's another bug, hoping this image can show it:

screen shot 2016-08-16 at 11 59 20 am

Reverting to < 1.0.

@tommoor
Copy link
Owner

tommoor commented Aug 16, 2016

Thanks @elado I'll blow away node_modules and take a look at this - I was probably referencing an outdated strategy format in dev would be my guess

@tommoor tommoor added the bug label Aug 16, 2016
@elado
Copy link
Author

elado commented Aug 16, 2016

In dev you might wanna use npm link.
Thanks!

@tommoor
Copy link
Owner

tommoor commented Aug 17, 2016

Closed by ec54ce8

Note: There is a bug in the emojione strategy file which means tones won't appear for some of the emojis until they fix it joypixels/emojione#330. In the meantime I've added a check so that the entire component doesn't fail in this case.

@tommoor tommoor closed this as completed Aug 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants