Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL not working (view isn't visible) #32

Closed
Shailevy opened this issue Feb 18, 2019 · 11 comments
Closed

RTL not working (view isn't visible) #32

Shailevy opened this issue Feb 18, 2019 · 11 comments

Comments

@Shailevy
Copy link

I'm using the WormDotsIndicator
My App is only in English but I have supportRtl=true in my manifest

When the device is in an RTL language the the view isn't visible (Although I can see it's taking the correct space when I do "Show layout bounds" on the device

@kar
Copy link

kar commented Feb 25, 2019

I can confirm this. I can only see one dot, and it's not animating at all.

@MohamedMohy9192
Copy link

I have the same problem ??

@Shailevy
Copy link
Author

If the layout direction isn't a bug issue you can add android:layoutDirection="LTR" for the layout holding the dots
If that isn't an option for you I suggest you fork the the library or fix it or use a different library .. unfortunately this issue is open for some time now

@midhilaj-flutter-developer

I am using SpringDotsIndicator and in rtl it is not working

@AliElDerawi
Copy link

If the layout direction isn't a bug issue you can add android:layoutDirection="LTR" for the layout holding the dots
If that isn't an option for you I suggest you fork the the library or fix it or use a different library .. unfortunately this issue is open for some time now

This solution fixes the issue, though it's not perfect, thanks for sharing.

@tommybuonomo
Copy link
Owner

Hi everybody,
Can someone try again with the last version 4.0 please.
Thanks

@abdulmuttaleb
Copy link

Still persists.

@tommybuonomo
Copy link
Owner

Hi everybody,
Can you please try with the new version 4.1 ?
Thanks

@Sabboo
Copy link

Sabboo commented Nov 9, 2019

Hi everybody,
Can you please try with the new version 4.1 ?
Thanks

I have tried it with version (4.1.2) and now its working fine. But a new problem arises because the method fun setViewPager(viewPager: ViewPager) only accepts ViewPager and it still not consistent with rtl mode. Google introduced ViewPager2 to solve these problems. So currently its working fine but only with ViewPager and its showing a reversed direction animation for the dots.

@tommybuonomo
Copy link
Owner

@Sabboo you have now the support of ViewPager2 using the method setViewPager2 instead of setViewPager

@Sabboo
Copy link

Sabboo commented Nov 9, 2019

@tommybuonomo Ah I didn't notice that, everything is working fine now.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants