Fix: Fetch updates of multiple companies

[sagard21]

Issue:
get_company_updates returns posts only from a single company despite passing correct urn_id and/or public_id.

Fix:

1. Remove the results list passed as parameter and create another variable results whose scope is local
2. Edit the iterator condition that checks for max results
3. Append the results to the results list

[abinpaul1]

Hi @sagard21 , Thanks a lot for this fix. Sorry I took a while to respond. There seems to be a problem in the amount of changes. It shows 900+ changes. It would be great if you could please look into that and update the PR.

[sagard21]

Hi Abin I actually raised a PR against a branch that already existed. It had many changes. Do you recommend I raise the fix against master or can you create a separate branch where I can push the fix?

On Tue, 26 Apr 2022 at 19:35, Abin K Paul ***@***.***> wrote: Hi @sagard21 <https://github.com/sagard21> , Thanks a lot for this fix. Sorry I took a while to respond. There seems to be a problem in the amount od changes. It shows 900+ changes. It would be great if you could please look into that and update the PR. — Reply to this email directly, view it on GitHub <#212 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AETP4QK5OLFMPEM3YFMZ423VG7Z3FANCNFSM5TWY756A> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Regards Sagar Dawda

[abinpaul1]

What you could do is sync your fork with this repo. Create a a new private branch from the master branch in your fork. Commit your changes to that, push the branch to your fork and open a PR to tomquirk:master.
Let me know if it's not clear.

[sagard21]

Cool Will do. Thanks Abin

On Thu, 28 Apr 2022 at 21:07, Abin K Paul ***@***.***> wrote: What you could do is sync your fork with this repo. Create a a new private branch from the master branch in your fork. Commit your changes to that, push the branch to your fork and open a PR to tomquirk:master. Let me know if it's not clear. — Reply to this email directly, view it on GitHub <#212 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AETP4QL5QICNM6UYO3RTHRTVHKWDTANCNFSM5TWY756A> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Regards Sagar Dawda