Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak: Remove one-time CSS #1143

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Conversation

tomusborne
Copy link
Owner

CSS generated by blocks should be specific to the individual block being rendered.

This PR removes all "one-time" CSS from the individual block output.

This means we could revert the generateblocks_skip_singular_css filter we had to add to integrate with Global Classes in GB Pro: https://github.com/tomusborne/generateblocks/blob/feature/pattern-library/includes/blocks/class-button.php#L173

@tomusborne tomusborne added the refactoring Refactoring, minor code changes label Nov 3, 2023
@tomusborne tomusborne added this to the 1.9.0 milestone Nov 3, 2023
@tomusborne tomusborne merged commit c26d345 into release/1.9.0 Dec 4, 2023
9 checks passed
@tomusborne tomusborne deleted the tweak/remove-one-time-css branch December 4, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactoring, minor code changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant