Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclamation point is not considered a valid symbol for function name #156

Closed
Skydev0h opened this issue Jan 15, 2024 · 3 comments
Closed

Exclamation point is not considered a valid symbol for function name #156

Skydev0h opened this issue Jan 15, 2024 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Skydev0h
Copy link

Skydev0h commented Jan 15, 2024 •
edited
Loading

The highlighter considers that ! cannot be used in function name.

image

While in reality it is perfectly fine and the code works.

Using the latest v2.0.4 plugin.
@Skydev0h Skydev0h changed the title Exclamation point is not considered a valid symbol for literal Exclamation point is not considered a valid symbol for function name Jan 15, 2024
@andreypfau andreypfau added bug Something isn't working good first issue Good for newcomers labels Jan 15, 2024
@andreypfau
Copy link
Member

Thank you for report, Will be fixed in next release

@andreypfau
Copy link
Member

andreypfau commented Jan 18, 2024 •
edited
Loading

I encountered a problem due to which I had to change the behavior of the lexer and parser, namely how the AST tree is built for ModifyExpression a~foo() and the usual ApplyExpression a foo(), foo(). Because of this, we will have to do a global refactoring of the code base so that there is no degradation in the functionality of current features in the IDE. It can take some time. Refactoring will also lead to issue #107 being fixed

But I hope to finish this soon, and the behavior of identifiers will be exactly the same as in the original FunC compiler. Thank you and stay tuned

andreypfau added a commit that referenced this issue Mar 23, 2024
@andreypfau
2.1.0 (#165)
4dcef48 
### Added

- Language selection in project template ([#148](#148))
- Empty and example project templates ([#147](#147))
- `#include` assist ([#108](#108))

### Fixed

- Negative method IDs are considered a syntax
  error ([#157](#157))
- Non-ASCII characters in FunC identifiers ([#156](#156))
- Invalid trailing comma in return tuple type ([#155](#155))
- Unresolved reference to uninitialized
  variable ([#151](#151))
- Invalid indent for multiline tuples in function signature return
  type ([#150](#150))
- Auto-complete not work on `slice~` ([#149](#149))
- `method_id` completion ([#126](#126))
- Reference resolving with identifiers containing non-letter
  characters ([#107](#107))
- Uppercase HEX in TL-B ([#100](#100))
- Indent in chain calls ([#38](#38))
@andreypfau
Copy link
Member

Fixed in 2.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Skydev0h @andreypfau