Set default values for TONCENTER_ENV and IMAGE_TAG #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdimentionaltree
requested changes
Jun 4, 2024
| * Create *.env* file with command `./configure.sh`. | ||
| * Run `./configure.sh --worker` to configure TON Index worker. | ||
| * Adjust parameters in *.env* file (see [list of available parameters](#available-parameters)). | ||
| * Build docker images: `docker compose build postgres alembic index-api`. | ||
| * Run stack: `docker compose up -d postgres alembic index-api`. | ||
| * To start worker use command `docker compose up -d index-worker` after creating all services. | ||
|
|
||
| **NOTE:** we recommend to setup indexer stack and index worker on separate servers. To install index worker to **Systemd** check this [instruction](https://github.com/kdimentionaltree/ton-index-cpp). | ||
| **NOTE:** we recommend to setup indexer stack and index worker on separate servers. To install index worker to **Systemd** check this [instruction](https://github.com/toncenter/ton-indexer). |
There was a problem hiding this comment.
Here a link to https://github.com/toncenter/ton-index-worker is required
| @@ -48,6 +48,7 @@ Do the following steps to setup TON Indexer: | |||
| * `TON_INDEXER_API_PORT`: a port to expose. You need check if this port is busy. Use different ports in case of multiple indexer instances on the same host. Default: `8081`. | |||
| * `TON_INDEXER_TON_HTTP_API_ENDPOINT`: an endpoint to [ton-http-api](https://github.com/toncenter/ton-http-api). Indexer API contains several proxy methods to ton-http-api service: `/message`, `/runGetMethod`, `/estimateFee`, `/account`, `/wallet`. If the variable is not set these methods will not be included. Default: `<blank>` | |||
| * `TON_INDEXER_WORKERS`: number of API workers. Default: `4`. | |||
| * `TONCENTER_ENV`: mainnet or testnet. Default: `mainnet`. | |||
There was a problem hiding this comment.
The environment variables TONCENTER_ENV, IMAGE_TAG together with a script "swarm-deploy.sh" are used to deploy in Docker Swarm mode. Sometimes the images of API and worker for mainnet and for testnet should be different.
The mistake in image in such case may cause critical issues. So, absence of default value in Compose files is the expected behavior.
Instead of specifying the default value I suggest to add these environment variables in script "configure.sh" and specify default values there.
|
The PR was closed because the absence of the default values is the expected behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found some bugs in the setup process for ton-indexer. Here is a small improvement to make it easier