Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple tempos / BPMs #63

Closed
pr0jectile opened this issue Sep 14, 2018 · 6 comments
Closed

Multiple tempos / BPMs #63

pr0jectile opened this issue Sep 14, 2018 · 6 comments

Comments

@pr0jectile
Copy link

I have some songs that use multiple BPMs, but when converting using your tool, I only get one BPM as the output.

Can you look into making this tool use multiple BPMs please as an array?

Thanks.

@appsforartists
Copy link
Collaborator

I don't speak for @tambien, so I have no idea if this is somewhere he's interested in taking it. I will say that PRs are more likely to be addressed than feature requests. 😃

@Topograph
Copy link

Topograph commented Nov 25, 2018

I also have problems with tracks including tempochanges...not sure how i can solve those

Edit: Nevermind. I found the duplicate thread of this one. And took the modified version from there....did the trick for me

@pr0jectile
Copy link
Author

I also have problems with tracks including tempochanges...not sure how i can solve those

Edit: Nevermind. I found the duplicate thread of this one. And took the modified version from there....did the trick for me

@Topograph Hey, do you mind sharing the relevant bits of code? Feels cluttered in that thread with all the commits.

@Topograph
Copy link

Hi,
It's been a while. I only found this one on my hard drive:
MidiConvertTime.js.txt
(rename the txt file to .js, GitHub seems to only allow certain file types in here ;). )

This seems to be a minified version. Sorry I found no other.
If I remember correctly this version considers the tempo changes when calculating the durations and starting timings in milliseconds of the notes.

@pr0jectile
Copy link
Author

@Topograph I figured out how to build using the commits from that thread in the end and the output result does match your version so I guess they both are the same. Thanks anyway! :)

@tambien
Copy link
Contributor

tambien commented Feb 15, 2019

should be fixed in the latest release. i compare all of the tempo changed timings against output i generated from pretty_midi, so i'm pretty sure they're accurate. the tempos are stored in an array of tempo events in the header file. if this array is modified, you have to update all of the note and cc time values by calling midi.header.update().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants