Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example's crash (#16) #18

Merged
merged 6 commits into from
Apr 20, 2020
Merged

Fix example's crash (#16) #18

merged 6 commits into from
Apr 20, 2020

Conversation

ales-tsurko
Copy link
Member

@ales-tsurko ales-tsurko commented Apr 17, 2020

Fixes #16
Possibly related to #17 No, it isn't

@ales-tsurko ales-tsurko added bug Something isn't working windows labels Apr 17, 2020
@ales-tsurko ales-tsurko self-assigned this Apr 17, 2020
@ales-tsurko ales-tsurko linked an issue Apr 17, 2020 that may be closed by this pull request
@ales-tsurko
Copy link
Member Author

ales-tsurko commented Apr 20, 2020

The cause of the crash is related to simple-log crate. I tried SimpleLogger without initialization of a file and it still crashes. But switching to another library (simple-logging, for ex.) fixes the problem.

Checked with log4rs — crashes too.

There is unwrap on mutex in Log trait implementation in simple-log. simple-logging makes it more safe, but it possibly just doesn't work sometimes, because it doesn't handle errors... Anyway it's fine for a log example and out of scope for the library.

@ales-tsurko ales-tsurko marked this pull request as ready for review April 20, 2020 22:44
@ales-tsurko ales-tsurko changed the title [WIP] Fix example's crash (#16) Fix example's crash (#16) Apr 20, 2020
@ales-tsurko ales-tsurko merged commit 1468bee into master Apr 20, 2020
@ales-tsurko ales-tsurko deleted the 16-fix-crash-win branch April 20, 2020 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin name displays incorrectly Example plugin causes FL to crash
1 participant