-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question: is it intended to be a standalone library, or is it part of Docker? #43
Comments
I'm curious about the same questions... Perhaps it would make sense to start tagging semantic releases. Thank you. See also |
There is currently no intention of making release versions of this package. Every project using these helper functions needs to vendor it to their codebase, at what point they become part of these projects source. Release versions of Docker/BuildKit/img use a specific commit defined in their source when they are built. |
Alright thanks for clarification! |
I'm not satisfied with this explanation. If this code is meant to be re-usable, then proper versioning could be useful. Common Golang vendoring practice is flawed. Incorporating re-usable code into larger code base makes it difficult to maintain that code, track updates, (let alone to provide incentive to do so). It is prohibitively difficult to provide meaningful security support. @tonistiigi, if main point of your code is to "become part of these projects source" then either your code should not occupy it own name space or it should be a proper reusable library. The latter is probably true if your code is not deprecated and intended to be practically used. |
Hi,
while attempting to package Docker for Debian, I came across this library. I first tried to package it as a standalone library, the way it's usually done in Debian, and bump into two problems, mainly:
So I'm just wondering what's the intent here. Does this library aims to become standalone, or is it just a part of Docker codebase that lives somewhere else for some reasons?
EDIT: I've seen that this library is also used in moby/buildkit, which is also difficult to package for the same reasons.
Thanks!
The text was updated successfully, but these errors were encountered: