Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: xx-apk failed to symlink compiler-rt on Alpine 3.18 #129

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

isac322
Copy link
Contributor

@isac322 isac322 commented Nov 25, 2023

Starting from Alpine 3.18, compiler-rt install on usr/lib/llvm* instead of usr/lib/clang. (Package contents of 3.17, 3.18) So xx-apk failed to create symlinks with error message below.

/opt/app # set -ex
/opt/app # xx-apk add compiler-rt
+ xx-apk add compiler-rt
+ apk  --root /aarch64-alpine-linux-musl add compiler-rt
OK: 55 MiB in 7 packages
find: /aarch64-alpine-linux-musl/usr/lib/clang: No such file or directory

Here is sample output of apk info -qL compiler-rt

/ # apk info -qL compiler-rt
usr/lib/clang/15.0.7/bin/hwasan_symbolize
usr/lib/clang/15.0.7/include/fuzzer/FuzzedDataProvider.h
usr/lib/clang/15.0.7/include/orc/c_api.h
usr/lib/clang/15.0.7/include/profile/InstrProfData.inc
usr/lib/clang/15.0.7/include/sanitizer/allocator_interface.h
usr/lib/clang/15.0.7/include/sanitizer/asan_interface.h
usr/lib/clang/15.0.7/include/sanitizer/common_interface_defs.h
usr/lib/clang/15.0.7/include/sanitizer/coverage_interface.h
usr/lib/clang/15.0.7/include/sanitizer/dfsan_interface.h
usr/lib/clang/15.0.7/include/sanitizer/hwasan_interface.h
usr/lib/clang/15.0.7/include/sanitizer/linux_syscall_hooks.h
usr/lib/clang/15.0.7/include/sanitizer/lsan_interface.h
usr/lib/clang/15.0.7/include/sanitizer/msan_interface.h
usr/lib/clang/15.0.7/include/sanitizer/netbsd_syscall_hooks.h
usr/lib/clang/15.0.7/include/sanitizer/scudo_interface.h
usr/lib/clang/15.0.7/include/sanitizer/tsan_interface.h
usr/lib/clang/15.0.7/include/sanitizer/tsan_interface_atomic.h
...

Copy link
Owner

@tonistiigi tonistiigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM but missing DCO and squash commits as well

Signed-off-by: Byeonghoon Yoo <bhyoo@bhyoo.com>
@tonistiigi tonistiigi merged commit 8db003e into tonistiigi:master Jan 5, 2024
21 of 24 checks passed
@isac322 isac322 deleted the fix-compiler-rt branch January 5, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants